Added html details > summary tag support for website #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
approved these changes
Jul 22, 2024
|
Can you merge this @rtfeldman? |
|
Cool, thanks @jfkonecn! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added html details > summary tag support for website
closes #6510
Explanation
I'm happy to change the colors and style however you want. My eye for UI isn't the best.
I spent most of my time trying to get animations to work which does not appear to have good builtin support with CSS.
I could only find solutions that added javascript or basically hacked the html so I decided against doing that since it is probably not worth the accessibility and usability headache.
Normal State
Hover State
Open State