Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end test with resampler #103

Open
gavv opened this issue May 29, 2023 · 0 comments
Open

Add end-to-end test with resampler #103

gavv opened this issue May 29, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests

Comments

@gavv
Copy link
Member

gavv commented May 29, 2023

TestEnd2End_Default is a simple integration test that writes samples to sender, reads them from receiver, and verifies the received stream.

TestEnd2End_Default disables resampler, so that the received stream is only minimally modified, as described in #101.

We should add a new test TestEnd2End_Resampler, that enables resampling on receiver by setting ReceiverConfig.ResamplerBackend and ResamplerProfile.

Since resampler modifies stream in a very complicated way, the acceptance criteria for this test should much more relaxed compared to #101. We can just wait until we accumulate 10'000 non-zero samples, ignoring zeros, and without checking actual sample values. However we still need to use tickers similar to described in #101.

See also: https://roc-streaming.org/toolkit/docs/internals/fe_resampler.html

@gavv gavv added help wanted Contributions are welcome tests Improvements or additions to tests good first issue Good for newcomers labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests
Projects
None yet
Development

No branches or pull requests

1 participant