Fix android build #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed soversion from soname, LogLevel class caching, fix thread attaching and detaching on logger_handler added internet permissions to AndroidManifest
|
I've tested changes. Fixes for logger and build are working 👍 |
ortex
reviewed
Jun 6, 2020
|
LGTM |
gavv
reviewed
Jun 7, 2020
gavv
reviewed
Jun 7, 2020
gavv
approved these changes
Jun 10, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following fixes:
soversionfromlibroc.solibraryLogLevelclass caching duringJNI_OnLoadlogger_handlerAndroidManifest.xml/resolve #15
/resolve #16