New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "int" for errors in JNI code #71

Merged

ortex merged 1 commit into roc-streaming:main from gavv:int

Apr 3, 2023

Member

gavv commented Apr 3, 2023

Use "int" instead of "char" as error types. int is more common and expected for errors. Also mixing int and char is confusing. Also char may be unsigned on some platforms.
Use "-1" instead of "1" when reporting errors. Using negative error numbers is more common and expected.


          Use "int" for errors in JNI code

a613a44

gavv requested a review from ortex

April 3, 2023 09:12

ortex reviewed

View reviewed changes

roc_jni/src/main/cpp/common.cpp

                       return 0;
                   }
                   return (unsigned int) ret;
               }
               long long get_llong_field_value(
-                  JNIEnv* env, jclass clazz, jobject obj, const char* attr_name, char* error) {
+                  JNIEnv* env, jclass clazz, jobject obj, const char* attr_name, int* error) {

Member

ortex Apr 3, 2023

nit: looks like we don't need int* error in this function

ortex merged commit cf1600b into roc-streaming:main

gavv deleted the int branch

April 3, 2023 10:44

gavv mentioned this pull request

Remove unnecessary error arguments in JNI common funcs? #75

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment