Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Map doesn't show up in example #142

Closed
luskah opened this issue Dec 31, 2020 · 8 comments
Closed

Google Map doesn't show up in example #142

luskah opened this issue Dec 31, 2020 · 8 comments
Labels

Comments

@luskah
Copy link

luskah commented Dec 31, 2020

Hello, thanks for the work !

However, I can't even display the Google Maps in the example code.
I already have a key for these Google Maps API so I added GoogleMaps(app, key = mykey)
image

Here is a screen of what I get one I run the python file:

unnamed

Thank you if you can help me figuring out where is the problem

@luskah luskah added the bug label Dec 31, 2020
@Herugrim
Copy link
Contributor

Herugrim commented Jan 1, 2021

I upgraded to 0.4.1 and encountered the same issue on my site. An omitted comma causes the javascript to break, I already made PR #143 to fix it.

@bhuveshsharma09
Copy link
Contributor

Thank you @luskah for reporting the bug.
Thanks, @Herugrim for resolving it already.

@rohitabraham5
Copy link

Hello All, Any idea when will the changes be merged and pushed? Thanks in advance

@anafdal
Copy link

anafdal commented Feb 17, 2021

I am still having the same issue. Is there anything we can do?

@ghost
Copy link

ghost commented Feb 24, 2021

The author is dead from COVID. It must be fixed manually.

@bhuveshsharma09
Copy link
Contributor

Hey Guys,
Waiting for #144 to merge. That will resolve the issue.

Meanwhile, you can consider following the instruction given in #144 .

@Herugrim
Copy link
Contributor

To be complete, PR #143 that fixes this bug was merged last week but no new release was done. In the meantime I made another PR #144 to iron out some extra things like loading unnecessary JavaScript. @bhuveshsharma09 could you please check out that PR? I asked for your input, if you can confirm that nothing breaks in the added functionality introduced in 0.4.1 then @Riverfount can merge #144 and create a new pip release.

In the meantime you can either add a comma manually as per #143 or install 0.4.0 manually:
pip install -I flask-googlemaps==0.4.0

@Riverfount
Copy link
Member

Hi guys I merged all the last PRs and create a new release of the extension. I hope that solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants