bugfix: Add default value fir signatures and marks

When syncing from a remote that has no marks or no signatures (older version) this ensures the field on sync defaults to empty list avoiding iteration error. fixes: pulp#1387
rochacbruno · Mar 3, 2023 · 5d354e8 · 5d354e8
1 parent da32f91
commit 5d354e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES/1387.bugfix b/CHANGES/1387.bugfix
@@ -0,0 +1 @@
+Fixed broken sync form servers without signatures or marks.
diff --git a/pulp_ansible/app/tasks/collections.py b/pulp_ansible/app/tasks/collections.py
@@ -589,8 +589,8 @@ async def _add_collection_version(self, api_version, collection_version_url, met
         self.already_synced.add(cv_unique)
 
         info = metadata["metadata"]
-        signatures = metadata.get("signatures")
-        marks = metadata.get("marks")  # List[str]
+        signatures = metadata.get("signatures", [])
+        marks = metadata.get("marks", [])
 
         if self.signed_only and not signatures:
             return