Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Tidy up #163

Merged
merged 3 commits into from
Jun 4, 2021
Merged

RF: Tidy up #163

merged 3 commits into from
Jun 4, 2021

Conversation

scottclowe
Copy link
Member

  • Don't need to import builtins.
  • Can always assume multiprocessing is available as it has been part of the standard library since Py 2.7.
  • Use os.path.join for building path to test data.

The multiprocessing package was moved to standard library in
Python 2.7, and we have already dropped Python 2.6 support.
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #163 (9870c1d) into master (2c54b62) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   92.38%   92.68%   +0.29%     
==========================================
  Files           9        9              
  Lines         788      779       -9     
  Branches      158      158              
==========================================
- Hits          728      722       -6     
+ Misses         32       29       -3     
  Partials       28       28              
Flag Coverage Δ
unittests 92.55% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/ROI.py 78.26% <ø> (-0.47%) ⬇️
fissa/readimagejrois.py 91.38% <ø> (-0.09%) ⬇️
fissa/roitools.py 88.98% <ø> (-0.10%) ⬇️
fissa/core.py 95.91% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c54b62...9870c1d. Read the comment docs.

@scottclowe scottclowe merged commit ab32a9e into rochefort-lab:master Jun 4, 2021
@scottclowe scottclowe deleted the rf_tidy-up branch June 4, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant