Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use ndarray for all outputs, not list for some #164

Merged
merged 1 commit into from Jun 7, 2021

Conversation

scottclowe
Copy link
Member

Because we make the first of each output type with list comprehension and then copy it with np.copy(), that means one output is a list of lists of x and the others are 2d numpy arrays of x.

This PR changes the odd-one-out so it is a numpy array as well.

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #164 (4898354) into master (ab32a9e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   92.68%   92.71%   +0.02%     
==========================================
  Files           9        9              
  Lines         779      782       +3     
  Branches      158      158              
==========================================
+ Hits          722      725       +3     
  Misses         29       29              
  Partials       28       28              
Flag Coverage Δ
unittests 92.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/core.py 95.96% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab32a9e...4898354. Read the comment docs.

@scottclowe scottclowe merged commit 2862985 into rochefort-lab:master Jun 7, 2021
@scottclowe scottclowe deleted the mnt_mixed-list-ndarray branch June 7, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants