RF: Migrate duplicated rois2masks code to function in roitools #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 93.06% 93.00% -0.07%
==========================================
Files 8 8
Lines 909 900 -9
Branches 188 180 -8
==========================================
- Hits 846 837 -9
Misses 32 32
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scottclowe
force-pushed
the
rf_rois2masks
branch
from
68d9cc1
to
7243638
Compare
scottclowe
force-pushed
the
rf_rois2masks
branch
from
7243638
to
f0cd6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following good software development practice, DRY: Don't repeat yourself, this replicated code should be refactored into a common function.
The only thing which differs is how the image shape is determined, and so I have introduced a function which produces that output and sends it to
roitools.rois2masks. We are still using DataHandler.rois2masks. For the builtin DataHandler classes, this trivially points toroitools.rois2masks(rois, self.get_image_size(data), but others could make "masks" be non-masks if they would like to have a different interface outside of roitools like @swkeemink was saying in #100.