Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Refactor neuropil.separate #188

Merged
merged 13 commits into from Jun 26, 2021
Merged

Conversation

scottclowe
Copy link
Member

  • Remove duplicated code by refactoring so we have common logic only once
  • By generalising the code, we enable working with arbitrary sklearn.decomposition classes (e.g. FactorAnalysis), though this feature is undocumented.
  • Documentation is improved.

@swkeemink Would be great if you could double-check my descriptions of the methodology for normalising the mixing matrix to rank the signals.

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #188 (d89a3d6) into master (7a4dcf5) will increase coverage by 1.45%.
The diff coverage is 97.05%.

❗ Current head d89a3d6 differs from pull request most recent head 78385ee. Consider uploading reports for the commit 78385ee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   92.29%   93.75%   +1.45%     
==========================================
  Files           8        8              
  Lines         935      912      -23     
  Branches      192      188       -4     
==========================================
- Hits          863      855       -8     
+ Misses         37       30       -7     
+ Partials       35       27       -8     
Flag Coverage Δ
nbsmoke 66.99% <35.29%> (?)
unittests 93.42% <97.05%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/neuropil.py 98.18% <97.05%> (+6.75%) ⬆️
fissa/roitools.py 88.98% <0.00%> (-1.25%) ⬇️
fissa/extraction.py 95.86% <0.00%> (+0.82%) ⬆️
fissa/core.py 97.12% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4dcf5...78385ee. Read the comment docs.

@scottclowe scottclowe merged commit 3a70ce0 into rochefort-lab:master Jun 26, 2021
@scottclowe scottclowe deleted the rf_neuropil branch June 26, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant