CI:GHA: Always run tests, don't skip based on content #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we always need to run on pushes to the master branch. We would like to skip running the tests on pushes to other branches which don't affect the codebase, but it is not clear to me if this is actually possible using just the github workflow event triggers.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
===========================================
+ Coverage 76.08% 93.08% +16.99%
===========================================
Files 8 8
Lines 895 911 +16
Branches 188 188
===========================================
+ Hits 681 848 +167
+ Misses 184 32 -152
- Partials 30 31 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #193 and #194 only affected the documentation and not the codebase. When the master branch was updated, the test workflow did not trigger because only paths in paths-ignore were updated. This is a problem for our coverage report, which was expecting to see these results but instead only saw Appveyor Windows builds.
We change the test workflow to run on all pushes. I would like to always run on master and skip running the tests on pushes to other branches which don't affect the codebase, but it is not clear to me if this is actually possible using just the github workflow event triggers.