API: Change the shape of deltaf_raw to have the same number of dimensions as other outputs #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottclowe
added
the
vX.Y.0 New Minor Release
scottclowe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 93.33% 92.46% -0.87%
==========================================
Files 8 8
Lines 930 1248 +318
Branches 195 294 +99
==========================================
+ Hits 868 1154 +286
- Misses 32 55 +23
- Partials 30 39 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scottclowe
force-pushed
the
api_deltaf-raw-shape
branch
3 times, most recently
from
f6f3c2c
to
26f641b
Compare
Add an extra dimension so the axes align with other attributes.
scottclowe
force-pushed
the
api_deltaf-raw-shape
branch
from
26f641b
to
a4633f2
Compare
swkeemink
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the shape of
experiment.deltaf_rawto be a numpy.ndarray of(cells, trials)each containing a numpy.ndarray shaped(1, time).The current inner shape is a vector
(time, ). This means the number of dimensions unexpectedly differs fromexperiment.rawandexperiment.deltaf_result, each of which is a numpy.ndarray of(cells, trials)each containing a numpy.ndarray shaped(regions, time).