API: Rename maxiter and maxtries to max_iter and max_tries #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottclowe
added
the
vX.Y.0 New Minor Release
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 8 8
Lines 941 941
Branches 197 197
=======================================
Hits 870 870
Misses 34 34
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scottclowe
force-pushed
the
api_rename-maxes
branch
from
e2e8923
to
b47e5aa
Compare
|
Requires #231. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In keeping with python style guides and the
max_iterargument used in sklearn e.g. NMF, these arguments should have an underscore in the name. This makes it a lot easier to read what the variable is.I did not impose this on #224 because we also want internal consistency. This PR changes the neuropil module as well as core.Experiment.