API:ENH: Adding raw traces as an output for the functional interface #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottclowe
reviewed
Jul 12, 2021
swkeemink
force-pushed
the
functional_raw
branch
from
09139a1
to
82ea6ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 8 8
Lines 1209 1209
Branches 302 302
=======================================
Hits 1138 1138
Misses 36 36
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Merged
DOC: removed version_added as the whole function will be added in this version
TST:BUG: fixed missing bracket
swkeemink
force-pushed
the
functional_raw
branch
from
82ea6ca
to
d157481
Compare
|
I have now updated the notebook to compare both the raw and separated traces. I also added an example to show how to inspect the neuropil region signals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful for new users to quickly get started with implementing FISSA, and an important part of that is comparing the raw extracted traces to the decontaminated ones. Previously the functional interface did not allow for that, and with this PR I make that a standard behavior. Now with deltaf calculation:
and without
See also #169 for more discussion on this.
For now this is a draft pull request, because #228 should be finished first so that I can implement those changes in the notebook easily, and then update the plotting accordingly.