New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Verbosity improvements #238
Merged
scottclowe
merged 48 commits into
rochefort-lab:master
from
scottclowe:enh_verb-improvements
Jul 12, 2021
Merged
ENH: Verbosity improvements #238
scottclowe
merged 48 commits into
rochefort-lab:master
from
scottclowe:enh_verb-improvements
Jul 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scottclowe
commented
Jul 12, 2021
- save, load, clear, calc_deltaf methods are now verbose (if verbosity>=1).
- More verbosity settings (more verbosity levels, now up to verbosity>=4).
- Progress within an single extraction process can be shown (verbosity>=3), along with which TIFF is being processed (verbosity>=2).
- Amount of time taken is shown when things are finished.
- (With verbosity>=2) the images and rois which will be processed are shown to the user before processing begins.
- With verbosity>=5, joblib becomes verbose as well.
ROIs are not necessarily cells.
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 93.05% 93.72% +0.66%
==========================================
Files 8 8
Lines 922 1068 +146
Branches 196 248 +52
==========================================
+ Hits 858 1001 +143
- Misses 33 34 +1
- Partials 31 33 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In refactoring at some point this was dropped. Now reinstated.
scottclowe
force-pushed
the
enh_verb-improvements
branch
from
July 12, 2021 19:12
e2c582c
to
938ecbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.