Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Verbosity improvements #238

Merged
merged 48 commits into from Jul 12, 2021

Conversation

scottclowe
Copy link
Member

  • save, load, clear, calc_deltaf methods are now verbose (if verbosity>=1).
  • More verbosity settings (more verbosity levels, now up to verbosity>=4).
  • Progress within an single extraction process can be shown (verbosity>=3), along with which TIFF is being processed (verbosity>=2).
  • Amount of time taken is shown when things are finished.
  • (With verbosity>=2) the images and rois which will be processed are shown to the user before processing begins.
  • With verbosity>=5, joblib becomes verbose as well.

ROIs are not necessarily cells.
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #238 (938ecbe) into master (ba0680e) will increase coverage by 0.66%.
The diff coverage is 97.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   93.05%   93.72%   +0.66%     
==========================================
  Files           8        8              
  Lines         922     1068     +146     
  Branches      196      248      +52     
==========================================
+ Hits          858     1001     +143     
- Misses         33       34       +1     
- Partials       31       33       +2     
Flag Coverage Δ
nbsmoke 59.64% <32.04%> (-5.65%) ⬇️
unittests 93.44% <97.23%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/deltaf.py 100.00% <ø> (ø)
fissa/neuropil.py 95.16% <33.33%> (-3.18%) ⬇️
fissa/core.py 96.39% <98.31%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0680e...938ecbe. Read the comment docs.

@scottclowe
Copy link
Member Author

I split off commit ab0860a that was updating the notebooks, so this PR will not interact with #228 now. The update to add a verbosity=2 example to the notebooks will be in a separate PR.

@scottclowe scottclowe merged commit 4179f2a into rochefort-lab:master Jul 12, 2021
@scottclowe scottclowe deleted the enh_verb-improvements branch July 12, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant