Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Compare analysis params when loading from cache #245

Merged
merged 33 commits into from Jul 16, 2021

Conversation

scottclowe
Copy link
Member

The load method now refuses to load if the analysis parameters in the cache do not match the parameters of the Experiment instance.

The method can be refined in future efforts, but I think it is advantageous to include as-is and then improve from there.

  • The current settings are possibly too aggressive. An error is thrown if load tries to load a cache which is not valid. Because load is called by __init__ if the cache already exists, this means an error is immediately thrown if an Experiment instance is created with different parameters to the existing cache.
  • We currently reject caches which have parameters that differ from unset default parameters.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #245 (4643ff4) into master (862a251) will increase coverage by 0.25%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   93.88%   94.13%   +0.25%     
==========================================
  Files           8        8              
  Lines        1095     1176      +81     
  Branches      254      288      +34     
==========================================
+ Hits         1028     1107      +79     
- Misses         34       35       +1     
- Partials       33       34       +1     
Flag Coverage Δ
nbsmoke 60.28% <54.44%> (-0.36%) ⬇️
unittests 93.87% <97.77%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/core.py 96.72% <97.77%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862a251...4643ff4. Read the comment docs.

@scottclowe scottclowe merged commit 1d61058 into rochefort-lab:master Jul 16, 2021
@scottclowe scottclowe deleted the enh_save-compare-params branch July 16, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant