New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Compare analysis params when loading from cache #245
Merged
scottclowe
merged 33 commits into
rochefort-lab:master
from
scottclowe:enh_save-compare-params
Jul 16, 2021
Merged
ENH: Compare analysis params when loading from cache #245
scottclowe
merged 33 commits into
rochefort-lab:master
from
scottclowe:enh_save-compare-params
Jul 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 93.88% 94.13% +0.25%
==========================================
Files 8 8
Lines 1095 1176 +81
Branches 254 288 +34
==========================================
+ Hits 1028 1107 +79
- Misses 34 35 +1
- Partials 33 34 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scottclowe
force-pushed
the
enh_save-compare-params
branch
from
July 13, 2021 22:37
8dea12f
to
41da64e
Compare
scottclowe
force-pushed
the
enh_save-compare-params
branch
from
July 15, 2021 01:03
9b23c0b
to
a3b96fd
Compare
scottclowe
force-pushed
the
enh_save-compare-params
branch
from
July 15, 2021 01:23
a3b96fd
to
623d0eb
Compare
scottclowe
force-pushed
the
enh_save-compare-params
branch
from
July 15, 2021 01:44
f6e4c4d
to
a72729f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load method now refuses to load if the analysis parameters in the cache do not match the parameters of the Experiment instance.
The method can be refined in future efforts, but I think it is advantageous to include as-is and then improve from there.
__init__
if the cache already exists, this means an error is immediately thrown if an Experiment instance is created with different parameters to the existing cache.