Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty tag needs to be empty string #3

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: empty tag needs to be empty string #3

merged 1 commit into from
Mar 17, 2022

Conversation

arv
Copy link
Contributor

@arv arv commented Mar 17, 2022

Using undefined as the default value for optional tag parameter lead
to "undefined" being printed.

@arv
fix: empty tag needs to be empty string
2ed65c2 
Using `undefined` as the default value for optional `tag` parameter lead
to `"undefined"` being printed.
@arv arv requested a review from grgbkr March 17, 2022 20:58
@arv arv enabled auto-merge (squash) March 17, 2022 20:58
@arv arv merged commit 3ca44f9 into main Mar 17, 2022
@arv arv deleted the arv/fix-optional-tag branch March 17, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgbkr grgbkr Awaiting requested review from grgbkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@arv