Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE wat #5

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE wat #5

wants to merge 1 commit into from

Conversation

phritz
Copy link
Contributor

@phritz phritz commented Mar 22, 2022

No description provided.

@arv
Copy link
Contributor

arv commented Mar 22, 2022

I agree this was confusing but it is working as intended.

One "DBG" comes from creating the initial OptionalLoggerImpl when we create the default OptionalLogger from the log level. Then there is another "DBG" coming from the instance of LogContext we are creating.

I think a lot of the complications comes from the parameter types of new LogContext which I was just trying to keep compatible with what we had from before

@phritz phritz closed this Mar 23, 2022
@phritz phritz deleted the ph/wat branch March 23, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phritz @arv