This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore: bundling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arv
approved these changes
Jul 16, 2022
| "out/*", | ||
| "!out/*.test.*" | ||
| ], | ||
| "exports": { |
aboodman
reviewed
Jul 18, 2022
| "next": ">=12.1.6", | ||
| "react-dom": ">=16.0 <18.0", | ||
| "replicache": ">=11.0.0", | ||
| "pg-mem": ">=2.5.0" |
There was a problem hiding this comment.
OOC, why make pg-mem a peer dep?
There was a problem hiding this comment.
I believe this can be removed.
aboodman
reviewed
Jul 20, 2022
| "types": "./out/frontend/index.d.ts", | ||
| "import": "./out/frontend/index.js" | ||
| }, | ||
| "./out/backend/supabase": { |
There was a problem hiding this comment.
What is this export for? I don't see it being used in the pending replicache-todo PR. I know that the frontend dir is pulling this in (kind of a hack), but I don't see why that would necessitate an export?
There was a problem hiding this comment.
I was having trouble getting next to ignore supabase backend dependencies for the frontend. However, I think this can be undone now now that everything is ESM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.