Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scan should return ScanItem[] instead of iterable #27

Closed
arv opened this issue Jun 11, 2020 · 2 comments
Closed

scan should return ScanItem[] instead of iterable #27

arv opened this issue Jun 11, 2020 · 2 comments

Comments

@arv
Copy link
Contributor

arv commented Jun 11, 2020

scan really returns an array and annotating it as Iterable just leads to an extra copy
@aboodman
Copy link
Contributor

scan needs a lot of work generally.

@arv
Copy link
Contributor Author

arv commented Jun 16, 2020

Closing in favor of #30

@arv arv closed this as completed Jun 16, 2020
aboodman pushed a commit that referenced this issue Oct 28, 2021
@whiten
Change non-transactional fns to have default impls. (#27)
c238e99 
Removes old hand-written versions of these in favor of simple wrappers
using Read or Write traits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arv @aboodman