Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicache scan never closes transaction #51

Closed
arv opened this issue Jul 7, 2020 · 0 comments · Fixed by #53
Closed

Replicache scan never closes transaction #51

arv opened this issue Jul 7, 2020 · 0 comments · Fixed by #53
Assignees

Comments

@arv
Copy link
Contributor

arv commented Jul 7, 2020

Found this when performance checking... It used to work"

async function scan() {
  const start = performance.now();
  let sum = 0;
  for await (const v of rep.scan()) {
    sum += v.a;
  }
  const total = performance.now() - start;
  console.log(total);
}

Looking at the log of repm test server closeTransaction is never called.

@arv arv self-assigned this Jul 7, 2020
arv added a commit to arv/replicache that referenced this issue Jul 8, 2020
`return` is only called with an abrubt completion (return, break and
throw).

Fixes rocicorp#51
@arv arv closed this as completed in #53 Jul 8, 2020
arv added a commit that referenced this issue Jul 8, 2020
`return` is only called with an abrubt completion (return, break and
throw).

Fixes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant