Miscellaneous bindings changes from integration #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler. Also reformat this file and add some debug logging of RPCs.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rocicorp/replicache-sdk-js/d2dbj9qvf |
phritz
reviewed
Sep 21, 2020
| if (beginSyncResult.syncHead !== '00000000000000000000000000000000') { | ||
| // replicache-client sends all zeros for null sync, | ||
| // repc sends empty string. | ||
| if (beginSyncResult.syncHead.replace(/0/g, '') !== '') { |
| @@ -272,7 +274,7 @@ export default class Replicache implements ReadTransaction { | |||
| } | |||
| } | |||
|
|
|||
| const {batchPushInfo} = syncInfo; | |||
| const {batchPushInfo} = {...syncInfo}; | |||
There was a problem hiding this comment.
we are still not returning this (the syncinfo), you or @arv please file an issue if it is important to prioritize
| checkStatus(syncInfo.clientViewInfo, 'client view'); | ||
| const {clientViewInfo} = {...syncInfo}; | ||
| if (clientViewInfo) { | ||
| checkStatus(syncInfo.clientViewInfo, 'client view'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.