feat!: Include versions in IDB name #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Simplified Dueling Dags we need to ensure that different tabs running different versions of Replicache do not interact with IDB data it does not know how to read/write. To achieve this the name if the IDB database now contains the `REPLICACHE_FORMAT_VERSION` (which is currently at `3`). The IDB name also contains the `schemaVersion` som if the schema changes a fresh IDB database is used. The motivation is the same. Multiple tabs with different schemaVersions should not interact with the same IDB database. BREAKING CHANGE Towards rocicorp#671
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rocicorp/replicache/Fyukp7EdZq3J72biaBqXg3B8DE5R |
aboodman
approved these changes
Dec 2, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Simplified Dueling Dags we need to ensure that different tabs
running different versions of Replicache do not interact with IDB data
it does not know how to read/write.
To achieve this the name if the IDB database now contains the
REPLICACHE_FORMAT_VERSION(which is currently at3).The IDB name also contains the
schemaVersionsom if the schema changesa fresh IDB database is used. The motivation is the same. Multiple tabs
with different schemaVersions should not interact with the same IDB
database.
BREAKING CHANGE
Towards #671