This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Implement checksums #31
Comments
ok here's what i think about this, feedback welcome requirements for checksumming in r:
non-requirements:
proposal:
how's this all sound? |
Sounds great. Yeah this is all much simpler. I still think that the serialization should be |
I believe this is complete, right @phritz |
This was referenced Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now the code is using the Noms hash as a checksum, which means that (a) the client and server need to agree on a (potentially old) version of Noms to use for the hash, and also that (b) we can't efficiently have the checksum be over a different serialization than the internal schema.
Originally I thought we'd use LtHash as an incremental hash but @phritz points out it is overpowered for what we need, because it is actually a fully homomorphic hash. I hadn't realized that.
Ideally we could find a simple hash to use here which is incremental. Maybe even an old fashioned checksum is sufficient? It doesn't need to be secure.
All this is doing is what a classic checksum does -- it's a sanity check that sync is working properly.
The text was updated successfully, but these errors were encountered: