Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ImageField from the NOT_NULL_TRUE_FIELDS. #84

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Remove ImageField from the NOT_NULL_TRUE_FIELDS. #84

merged 2 commits into from
Jan 19, 2021

Conversation

mrswats
Copy link
Contributor

@mrswats mrswats commented Jan 19, 2021

ImageField is not a CharField and therefore it should not be checked by DJ01.

@mrswats
Copy link
Contributor Author

mrswats commented Jan 19, 2021

@rocioar Should FileField be removed this way as well?

@rocioar
Copy link
Owner

rocioar commented Jan 19, 2021

Yes, good call.

@mrswats mrswats mentioned this pull request Jan 19, 2021
@rocioar rocioar merged commit 55c976b into rocioar:master Jan 19, 2021
@rsalmaso
Copy link

🤔
https://code.djangoproject.com/ticket/10244
FileField/ImageField are not a CharField, but they behave the same.

and in https://docs.djangoproject.com/en/3.1/ref/models/fields/#filefield

FileField instances are created in your database as varchar columns with a default max length of 100 characters. As with other fields, you can change the maximum length using the max_length argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants