Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(roc-plugin-repo): Add semver utilities tests #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

test(roc-plugin-repo): Add semver utilities tests #12

wants to merge 7 commits into from

Conversation

kjarmicki
Copy link
Contributor

Just a beginning of what could eventually become extensions-wide tests. Started with semver utils because they seemed to fit the time scope of the hackday.

Copy link
Member

@dlmr dlmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good just one small change! 👍

.travis.yml Outdated
@@ -5,4 +5,5 @@ cache:
node_js:
- 6.9
before_script:
- git fetch --unshallow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need this anymore after 21997dd was merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may still need it just for tests, the change was done in generateStatus.js and tests don't touch that file, so that path remains broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maybe it's still needed here then and given that the tests seems to fail now it kinda points to that.

@dlmr dlmr force-pushed the master branch 2 times, most recently from 86b5b55 to e748478 Compare December 14, 2017 13:47
@dlmr dlmr force-pushed the master branch 3 times, most recently from 9aa26cb to 872a53c Compare January 3, 2018 16:04
@dlmr dlmr force-pushed the master branch 4 times, most recently from 86c5cf8 to 4a61efd Compare January 16, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants