Async resolver #165
Merged
Async resolver #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Third argument changed to an optional option object - The option object supports defining a custom resolver - Custom resolvers will get an additional argument, the identifier
This solves a bug that would cause issues if the folder name contained RegExp characters.
kjarmicki
reviewed
Apr 3, 2017
src/require/createResolveRequest.js
Outdated
| const log = require('debug')('roc:core:require'); // eslint-disable-line | ||
|
|
||
| const contextCache = {}; | ||
| const pattern = /^([^\/]*)\/?([^\/]*)/; |
There was a problem hiding this comment.
Maybe better name for a variable would be information what this pattern is looking for?
andreasrs
approved these changes
Apr 5, 2017
kjarmicki
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a breaking change for direct consumers of the resolver that used the third argument to enable fallback. This does not affect projects generally but rather some extensions.