Pass data to Handlebars as options #177
Conversation
| @@ -73,7 +73,7 @@ function filterFiles(filters) { | |||
| function render(template, data, callback) { | |||
| let rendered; | |||
| try { | |||
| rendered = Handlebars.compile(template)(data); | |||
| rendered = Handlebars.compile(template, data)(data); | |||
There was a problem hiding this comment.
What do you think about adding { noEscape: true } directly here, it is something we actually always want to use and means that we do not need to "pollute" data by overloading it.
There was a problem hiding this comment.
Do we want { noEscape: true } for all the usages of render? In renderTemplateFiles it was previously used without it, as metadata was taken directly from metalsmith.
Maybe we should instead open up render to use separate data and options and pass noEscape in options only when rendering log message?
There was a problem hiding this comment.
I think we always want to use noEscape and it was a bug that this was not done before. We could address this later however since it might be unrelated to the changes suggested here.
There was a problem hiding this comment.
I think it's a good time to address it since this PR is related to that, so if you don't mind I'd like to adjust it with that change sometime tomorrow :)
FIxes regression introduced in #171 where
noEscapewas not passed into Handlebars anymore.