Windows support #97
Merged
Windows support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I will try to test this out on Windows as soon as possible, looks really good. Yeah, we would like to support npm2 and I might be able to put some work into that during this weekend but it has not been a priority so far unfortunately. |
|
I managed to test this on Windows and the changes works great, thanks again! This is however unfortunately not the only things that needs to be addressed for Windows support. We will continue looking into this and document/fix the problems as we go along. I will go ahead and merge this and we will take it from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets past the initial spawning issue on Windows - I can't tell you if it works yet as I'm on npm2 so it's been installing duplicate versions of roc, Babel 6 etc on my test app for the last 30 minutes 😸
#91