chore: fix rubocop and enable/disable new cops #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other ones are disabled instead in the rubocop_todo file.
|
CI fails in the currently opened autoproj pull requests because of a change in an existing cop. Fix that, and use the opportunity to enable/disable new cops (leaving them disabled if fixing their warnings is non-trivial) |
g-arjones
approved these changes
Oct 18, 2021
2maz
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails in the currently opened autoproj pull requests because of a change in an existing cop. Fix that, and use the opportunity to enable/disable new cops (leaving them disabled if fixing their warnings is non-trivial)