don't overwrie python shims during install #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to admit I forgot about it when I reviewed the PR that creates the stub. A safer way would be to detect whether the binstub is a ruby script generated by bundler and ignore everything else. They all have a "This file was generated by Bundler" comment, and a she-bang line with |
|
Possibly, just the she-bang line would be enough tbh. This is a controlled folder, anything ruby has been generated by bundler. |
g-arjones
force-pushed
the
dont_overwrite_python_shims
branch
from
932b67f
to
1085a49
Compare
|
Done. |
g-arjones
force-pushed
the
dont_overwrite_python_shims
branch
from
1085a49
to
b061405
Compare
doudou
approved these changes
Dec 6, 2021
|
Thanks for the fix! @g-arjones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
I had no idea autoproj would overwrite everything in
.autoproj/bin.