Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move iodrivers_base to github #13

Merged
merged 2 commits into from Aug 20, 2014
Merged

Conversation

doudou
Copy link
Member

@doudou doudou commented Aug 19, 2014

No description provided.

@goldhoorn
Copy link
Contributor

I also don't really like this in the long run if you have 20 packages this make the source definition quire unreadable. Is there a way to generate the source file on-the-fly through ruby, then we could use a array. But this whould end up in removing the source.yml in general... (which i would like)

@goldhoorn
Copy link
Contributor

But for know i assume it's okay

@doudou
Copy link
Member Author

doudou commented Aug 19, 2014

I personally have no problem with removing the source.yml. The problem is
that we then cannot have common definitions (such as the common rock
definitions), which makes everything a lot more verbose.

On Tue, Aug 19, 2014 at 9:25 AM, Matthias Goldhoorn <
notifications@github.com> wrote:

I also don't really like this in the long run if you have 20 packages this
make the source definition quire unreadable. Is there a way to generate the
source file on-the-fly through ruby, then we could use a array. But this
whould end up in removing the source.yml in general... (which i would like)


Reply to this email directly or view it on GitHub
#13 (comment)
.

@doudou
Copy link
Member Author

doudou commented Aug 19, 2014

And it is a lot more work ...

@goldhoorn
Copy link
Contributor

Is there a (easy?) way to fill it from the libs|orogen.autobuild file directly instead of defining it in the source.yml. Or is this interface from autoproj/autobuild not accessable?

@doudou
Copy link
Member Author

doudou commented Aug 19, 2014

There is an easy way. However, what would you do with the overrides ? Git merging is going to be hell as well. And it will make the autobuild files significantly more complicated (since we'll have both the source and the build information).

In other words, it will suck IMO more than the current situation.

@doudou
Copy link
Member Author

doudou commented Aug 19, 2014

There;s already been a beginning of discussion about cleaning up the
autoproj configuration structure to avoid having too many separate files. I
am happy if you want to continue it, but I really don't believe that it is
the place.

On Tue, Aug 19, 2014 at 5:53 PM, Matthias Goldhoorn <
notifications@github.com> wrote:

Is there a (easy?) way to fill it from the libs|orogen.autobuild file
directly instead of defining it in the source.yml. Or is this interface
from autoproj/autobuild not accessable?


Reply to this email directly or view it on GitHub
#13 (comment)
.

@goldhoorn
Copy link
Contributor

Feel free to merge, but we need a place for such discussions...

On 20.08.2014 00:04, Sylvain Joyeux wrote:

There;s already been a beginning of discussion about cleaning up the
autoproj configuration structure to avoid having too many separate
files. I
am happy if you want to continue it, but I really don't believe that
it is
the place.

On Tue, Aug 19, 2014 at 5:53 PM, Matthias Goldhoorn <
notifications@github.com> wrote:

Is there a (easy?) way to fill it from the libs|orogen.autobuild file
directly instead of defining it in the source.yml. Or is this interface
from autoproj/autobuild not accessable?


Reply to this email directly or view it on GitHub

#13 (comment)
.


Reply to this email directly or view it on GitHub
#13 (comment).

… to github

Putting all packages in a single source line will cause merging hell
@doudou
Copy link
Member Author

doudou commented Aug 20, 2014

What about: the wiki, the mailing list ? Like for all such kind of issues ?

jmachowinski added a commit that referenced this pull request Aug 20, 2014
@jmachowinski jmachowinski merged commit d2f8e01 into master Aug 20, 2014
@doudou doudou deleted the move_iodrivers_base_to_github branch August 20, 2014 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants