Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass options to our gdb stub through miDebuggerArgs #69

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

doudou
Copy link
Member

@doudou doudou commented Mar 31, 2020

Until now, we were using the environment array. It seems that the
latest update started passing the environment through commands to
the debugger instead of through the shell environment.

Passing it through miDebuggerArgs seems to be the right thing to
do anyways.

Until now, we were using the `environment` array. It seems that the
latest update started passing the environment through commands to
the debugger instead of through the shell environment.

Passing it through miDebuggerArgs seems to be the right thing to
do anyways.
@doudou doudou requested a review from g-arjones March 31, 2020 16:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 116

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.443%

Totals Coverage Status
Change from base Build 114: 0.01%
Covered Lines: 1115
Relevant Lines: 1393

💛 - Coveralls

@doudou doudou merged commit 2b0711c into master Apr 1, 2020
@doudou doudou deleted the fix_gdb_stub branch April 1, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants