Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stubs/gdb to be independent of the order of vscode-provided arguments #70

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

doudou
Copy link
Member

@doudou doudou commented Apr 15, 2020

It seems that in some cases the C++ extension will add arguments before
our own to the stub script. Luckily, all vscode-provided arguments
are -- arguments, so filter on that.

…ents

It seems that in some cases the C++ extension will add arguments before
our own to the stub script. Luckily, all vscode-provided arguments
are `--` arguments, so filter on that.
@doudou doudou requested a review from g-arjones April 15, 2020 17:28
Copy link

@henriquejsfj henriquejsfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this solved the problem!

@doudou doudou merged commit 5fde7fd into master Apr 16, 2020
@doudou doudou deleted the fix_gdb_stub branch April 16, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants