Skip to content

Commit

Permalink
f2fs: fix memory leak of percpu counter in fill_super()
Browse files Browse the repository at this point in the history
In fill_super -> init_percpu_info, we should destroy percpu counter
in error path, otherwise memory allcoated for percpu counter will
leak.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
chaseyu authored and Jaegeuk Kim committed Sep 12, 2018
1 parent 0b2103e commit 4a70e25
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion fs/f2fs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -2458,8 +2458,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi)
if (err)
return err;

return percpu_counter_init(&sbi->total_valid_inode_count, 0,
err = percpu_counter_init(&sbi->total_valid_inode_count, 0,
GFP_KERNEL);
if (err)
percpu_counter_destroy(&sbi->alloc_valid_block_count);

return err;
}

#ifdef CONFIG_BLK_DEV_ZONED
Expand Down

0 comments on commit 4a70e25

Please sign in to comment.