Skip to content

Commit

Permalink
[mpp_service]: Fix error on reg offset setup
Browse files Browse the repository at this point in the history
Fix error in commit fb3390c
Error log:

[   60.923201] rk_vcodec: reg[-2080222496] + offset 127
[   60.923216] Unable to handle kernel paging request at virtual address ffffff83263859f4
[   61.004607] Mem abort info:
[   61.004877]   ESR = 0x96000005
[   61.005154]   EC = 0x25: DABT (current EL), IL = 32 bits
[   61.005623]   SET = 0, FnV = 0
[   61.005898]   EA = 0, S1PTW = 0
[   61.006172] Data abort info:
[   61.006425]   ISV = 0, ISS = 0x00000005
[   61.006764]   CM = 0, WnR = 0
[   61.007031] swapper pgtable: 4k pages, 39-bit VAs, pgdp=00000000017e5000
[   61.007621] [ffffff83263859f4] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000
[   61.008407] Internal error: Oops: 96000005 [#1] SMP
[   61.008835] Modules linked in: rk_vcodec
[   61.009194] CPU: 1 PID: 1537 Comm: mpp_dec_parser Not tainted 5.10.66 #10
[   61.009793] Hardware name: Rockchip RK3588 EVB3 LP5 V10 Board (DT)
[   61.010340] pstate: 60400009 (nZCv daif +PAN -UAO -TCO BTYPE=--)
[   61.010900] pc : mpp_translate_reg_offset_info+0xec/0xfc [rk_vcodec]
[   61.011469] lr : mpp_translate_reg_offset_info+0xdc/0xfc [rk_vcodec]
[   61.012025] sp : ffffffc013f33a90

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Herman Chen <herman.chen@rock-chips.com>
Change-Id: I023db0c7c930ec54bfbc1141bef3543a295b165a
  • Loading branch information
Caesar-github authored and HermanChen committed Feb 15, 2022
1 parent 9ffb11c commit 5c0859c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions osal/driver/mpp_service.c
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,6 @@ MPP_RET mpp_service_reg_offset(void *ctx, MppDevRegOffsetCfg *cfg)
info = mpp_service_next_reg_offset(p);;
info->reg_idx = cfg->reg_idx;
info->offset = cfg->offset;
p->reg_offset_count++;

return MPP_OK;
}
Expand Down Expand Up @@ -510,7 +509,6 @@ MPP_RET mpp_service_reg_offsets(void *ctx, MppDevRegOffCfgs *cfgs)
info = mpp_service_next_reg_offset(p);;
info->reg_idx = cfg->reg_idx;
info->offset = cfg->offset;
p->reg_offset_count++;
}

return MPP_OK;
Expand Down

0 comments on commit 5c0859c

Please sign in to comment.