Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Do not use full_path for file objects #210

Closed
wants to merge 1 commit into from

Conversation

nirbheek
Copy link
Contributor

The full path will be inserted automatically here.

The full path will be inserted automatically here.
@eli-schwartz
Copy link
Collaborator

The full path will be inserted automatically here.

Unfortunately, this is false. It would work if the custom_target was added as its own array element to a command: kwarg. The generated compiler macro is:

'-DPSL_DAFSA="<CustomTarget 59830eb@@psl.dafsa@cus: ['"'"'/usr/bin/python3.10'"'"', <File: src/psl-make-dafsa (not built)>, '"'"'--output-format=binary'"'"', '"'"'@INPUT@'"'"', '"'"'@OUTPUT@'"'"']>"'

mesonbuild/meson#11834 would make this into a warning:

NOTICE: Future-deprecated features used:
 * 1.2.0: {'str.format: Value other than strings, integers, bools, options, dictionaries and lists thereof.'}

@nirbheek nirbheek deleted the full-path branch July 12, 2023 18:49
@nirbheek
Copy link
Contributor Author

Okay, then we have to do this: #211

@eli-schwartz
Copy link
Collaborator

Yup, that looks a lot safer and should probably work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants