Add NMake Makefiles for Visual Studio builds #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a set of Visual Studio NMake Makefiles that can be used to build libpsl, either as a DLL or as a static .lib. Building of the psl tool and the tests in tests/ (but not fuzz, since those tests use fmemopen(), that is not supported on Windows) are also supported. A simplified "install" target is provided that copies the build results to a default or set prefix with the pkg-config file so that other packages (such as libsoup) with build systems that depend on this .pc file can be built. These files make use of autotools stuff so that they have the up-to-date version info upon a release. Currently, only builds using the ICU runtime/builtin or with no runtime/builtin are supported with Visual Studio builds.
|
Great, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This adds a set of NMake Makefiles and associated items for building libpsl using Visual Studio's NMake. This also pulls out the source listings of libpsl into a separate Makefile snippet so that it can be included by both the autotools Makefile.am and the NMake Makefiles for the build.
This attempts to make things modularized and this reuses items that have been used in the past for building items such as HarfBuzz (which I maintained the NMake Makefiles for it before it switched to CMake), due to the differences between GNUish Make and NMake. Due to the complexity of building libidn/libidn2 with libunistring using Visual Studio, currently only builds using libicu as the runtime/builtin, or builds without runtime/builtin usage are supported with this set of NMake Makefiles.
With blessings, thank you!