Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut-dirs is broken #170

Closed
5hd opened this issue Apr 5, 2017 · 3 comments
Closed

cut-dirs is broken #170

5hd opened this issue Apr 5, 2017 · 3 comments

Comments

@5hd
Copy link

5hd commented Apr 5, 2017

As I understand it, currently the "cut-dirs" setting is broken.
Issues I encountered:

  • --cut-dirs=1 together with --no-host-directories will fail to save any file
  • leading / should be removed

See my commit here: MichaelRoosz@fb665a1

@rockdaboot
Copy link
Owner

(Sorry if you get this twice (also put as comment to your commit))

Thanks for having a look at it.
Please create a pull request (PR) - then your changes are automatically checked by our Continuous Integration (Travis CI). If that passes, I'll do a manual review.

If you have time and joy, please add a test case to reproduce a/the problem (see tests/test.*.c as examples).

@MichaelRoosz
Copy link

Okay, I will give it a try in a few days, if I find the time.

@rockdaboot
Copy link
Owner

Fixed by #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants