Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with R 4.0.0 and 4.0.2 containers #41

Closed
julou opened this issue Jul 9, 2020 · 10 comments
Closed

bug with R 4.0.0 and 4.0.2 containers #41

julou opened this issue Jul 9, 2020 · 10 comments

Comments

@julou
Copy link

julou commented Jul 9, 2020

Not sure where this bug report (jupyterhub/jupyter-rsession-proxy#92) should be posted at best, so cross-posting here as it seems to be rocker-binder's home.
Sorry if this is bad practice (feel free to close/delete the least appropriate issues in this case) and thank you in advance for your help!

@cboettig
Copy link
Member

cboettig commented Jul 9, 2020

@julou Thanks for the report! Yup, missed a CMD in the new mapping. My apologies. Rebuilding the 4.0.x images now and should be up in a little bit.

p.s. the new 4.0.x images now use the RStudio Package Manager binary builds for Ubuntu Focal (20.04), which should dramatically reduce install times when using binder.

Again thanks for the report; yeah, any rocker based image issues are best filed in these repos just so I see it. apologies we hadn't caught this!

@julou
Copy link
Author

julou commented Jul 10, 2020

Glad that I finally reached the right place ><

I will sound dense here, but could you please instruct how I could force reloading the binder image. Because I now see the 4.0.1 images on dockerhub and all 4.0.x images have an update time that is after your last message so I believe they have been updated but neither https://mybinder.org/v2/gh/rocker-org/binder/master?urlpath=rstudio nor https://mybinder.org/v2/gh/julou/BinderWithR/master?urlpath=rstudio works.

In fact I'm not sure whether it's a refresh issue or that a bug is still lying around: I even updated https://mybinder.org/v2/gh/julou/BinderWithR/master?urlpath=rstudio to force it using 4.0.1 since I know this one is new, but I get the exact same error message…

@julou
Copy link
Author

julou commented Jul 10, 2020

p.s. the new 4.0.x images now use the RStudio Package Manager binary builds for Ubuntu Focal (20.04), which should dramatically reduce install times when using binder.

that's great news!
In fact I already included this feature for restoring renv with my R-3.6.3 images.

@cboettig
Copy link
Member

Whoopsies, that's what I get for replying to the thread before waiting for the image to finish building. Had also forgotten to drop out of root and back to USER in the Dockerfile. It's building again, let's both check again once the new images repost

@julou
Copy link
Author

julou commented Jul 11, 2020

Thanks for following up. Still getting the following on both repos:

Step 7/9 : RUN chown -R ${NB_USER} ${HOME}
 ---> Running in 2543131df3dd
chown: invalid user: ‘jovyan’
Removing intermediate container 2543131df3dd
The command '/bin/sh -c chown -R ${NB_USER} ${HOME}' returned a non-zero code: 1

@julou
Copy link
Author

julou commented Jul 15, 2020

Yeah… it now works! Thank you very much :)
Now I have to figure out how to get renv installed on 4.0.x images (which works flawlessly in e.g. 3.6 but somehow crashes on 4.0.x). I might open another issue soon :-/

@julou
Copy link
Author

julou commented Jul 15, 2020

well… maybe I claimed victory too early!
It turns out that with the current images, the GitHub repo is copied at the root of the file system, instead of in the home directory… Am I right thinking that this must be solved in the Docker image?

@cboettig
Copy link
Member

Thanks! yeah, you can always address these in your Dockerfiles in the repos, but I think it would be nicer for us to set that in our Dockerfiles for convenience. Thanks for pointing that out, I'll add a WORKDIR call in now.

@cboettig
Copy link
Member

I think we should finally be all good here? At least things look ok if you click the binder button in this repo. e.g. https://mybinder.org/v2/gh/rocker-org/binder/master?urlpath=rstudio

@julou
Copy link
Author

julou commented Aug 2, 2020

hi @cboettig,
I'm sorry for being picky but with the current rocker-org/binder, I get the studio session started in /home/rstudio while I see the content of https://github.com/rocker-org/binder at the root of the filesystem. Isn't it what you intended to fix?
In any case I find it very confusing, I'd expect that one creates a directory with the name of the repo (in this case, probably /home/binder, but maybe /binder is better for some reason), clone the repo inside, and start the rstudio session from there…
Sorry again if this is not relevant. And thanks a lot for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants