Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream effects from switching the CRAN env var to https://packagemanager.rstudio.com #50

Closed
lcolladotor opened this issue May 19, 2020 · 3 comments

Comments

@lcolladotor
Copy link

lcolladotor commented May 19, 2020

Hi,

I've noticed that GitHub Actions (GHA) workflows that depend on the rocker docker images have had a bit of a hiccup lately with remotes::install_dev("pkgdown") as I reported at r-lib/remotes#501. It seems like the root issue was the recent change at 2dcd686 which switched the CRAN environment variable from https://cran.r-project.org to https://packagemanager.rstudio.com/all/__linux__/bionic/latest in most cases. Jim Hester at r-lib/remotes#501 (comment) suggests that options(repos = c(RSPM = "xyz", CRAN = 'abc')) is the better way to use the RSPM, so would it be ok to:

  • revert the CRAN environment variable?
  • set the RSPM environment variable to https://packagemanager.rstudio.com/all/__linux__/bionic/latest/ (like you had done already)?

I ignore if there were other reasons why you changed CRAN, but if you want, I can send a PR that does these 2 changes.

Best,
Leo

lcolladotor added a commit to lcolladotor/rocker-versioned2 that referenced this issue May 19, 2020
As discussed at rocker-org#50 and
r-lib/remotes#501, for using the RStudio Package
Manager, it seems like the best option is to set the `RSPM` environment variable
instead of changing the `CRAN` one. This commit reverts
rocker-org@2dcd686
and adds the RSPM environment variable.
@lcolladotor
Copy link
Author

Hi,

Given that resolving this issue (in appearance) seemed straight forward, I just sent a PR with the suggested code changes.

Best,
Leo

lcolladotor added a commit to LieberInstitute/recount3 that referenced this issue May 27, 2020
lcolladotor added a commit to lcolladotor/biocthis that referenced this issue May 27, 2020
@cboettig
Copy link
Member

@lcolladotor given discussion in #51 I think we can close this?

@lcolladotor
Copy link
Author

Yes, based on the promise of adding support for remotes::install_dev() in the RSPM noted at #51 (comment). Plus the remotes::install_github() temporary workaround.

Thanks again for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants