Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install_julia.sh #269

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Add install_julia.sh #269

merged 5 commits into from
Oct 25, 2021

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Oct 20, 2021

Close #128
Add a script to install Julia and two different packages for using Julia from R.
This is a continuation of #157, work by @grantmcdermott.

The following changes were made to make it behave like the other rocker scripts.

  • Multi-architecture support
  • Automatically get the latest version of Julia
  • Create a symbolic link instead of changing the PATH environment variable
  • Omit installation of Julia packages

The reason why I left out the installation of the package RCall.jl for using R from Julia is that Julia packages are basically installed on a per-user basis.
Given that the user running the script (root) and the user using Julia (e.g. rstudio) are likely to be different, I thought it would be of little use to install RCall.jl within this script.

@grantmcdermott How about it?

ToDo

  • Update the NEWS.md

grantmcdermott and others added 4 commits May 12, 2021 00:35
- Multi-architecture support
- Automatically get the latest version of Julia
- Create a symbolic link instead of changing the PATH environment variable
- Omit installation of Julia packages
@cboettig
Copy link
Member

This looks good to me.

@grantmcdermott any thoughts here?

@grantmcdermott
Copy link
Contributor

grantmcdermott commented Oct 22, 2021

Yeah, looks great. The point about RCall.jl and per-user installation is a bummer, but probably correct. There might be a way to enable via symlinks or instantiating dedicated projects for the root and rstudio users in the Dockerfile... but that would probably require more work than can be justified. I would just leave a note somewhere that users should expect to install RCall.jl themselves if they want it.

PS. Sorry, @eitsupi for dropping the ball w.r.t. to your comments on my previous PR. But I'm happy to close #157 in favour of this.

@eitsupi
Copy link
Member Author

eitsupi commented Oct 22, 2021

Note: I found comments that the environment variable JULIA_DEPOT_PATH can be used to control the directory where the packages are installed, but after a few tries, I could not use packages installed by root from non-root user.
The environment variable is also set in the Docker image by Project Jupyter https://github.com/jupyter/docker-stacks/blob/82ce73789ba4ae47c49110f326da501fdbb91bf5/datascience-notebook/Dockerfile#L30, which Python, R, and Julia are installed, but I still could not invoke the installed Julia packages in the Dockerfile when I switched users.

@cboettig
Copy link
Member

👍

@eitsupi eitsupi marked this pull request as ready for review October 25, 2021 15:38
@eitsupi
Copy link
Member Author

eitsupi commented Oct 25, 2021

@cboettig Thank you for your review.
The flaw in docker-bake.json that was causing the build to fail should have been fixed in #274, so I hope you can merge this PR and build it. (if it fails to build, I'll fix it tomorrow......)

@cboettig cboettig merged commit 94e8877 into rocker-org:master Oct 25, 2021
@eitsupi eitsupi deleted the add-install-julia branch October 25, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install_julia script
3 participants