Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder: Install packages required for Jupyter to PDF convert #714

Merged
merged 12 commits into from
Oct 20, 2023

Conversation

yuvipanda
Copy link
Contributor

Per jupyter/nbconvert#1328, these are the packages needed for Jupyter to be able to convert to PDF. Without it, you get unfriendly errors like [this] (2i2c-org/infrastructure#3188 (comment)).

Given that the binder image includes jupyter, and texlive is included in the base, I hope it would be reasonable for the binder image to include enough texlive packages for PDF conversion to work. Otherwise, it works in RStudio but not in Jupyter.

Per jupyter/nbconvert#1328, these
are the packages needed for Jupyter to be able to convert
to PDF. Without it, you get unfriendly errors like [this]
(2i2c-org/infrastructure#3188 (comment)).

Given that the binder image includes jupyter, and texlive is included
in the base, I hope it would be reasonable for the binder image
to include enough texlive packages for PDF conversion to work.
Otherwise, it works in RStudio but not in Jupyter.
@yuvipanda
Copy link
Contributor Author

ok I'm confused now, because tlmgr isn't found in and the script is failing, but I do see tlmgr in PATH when I'm running the container.

@eitsupi
Copy link
Member

eitsupi commented Oct 18, 2023

tlmgr isn't found in and the script is failing, but I do see tlmgr in PATH when I'm running the container.

I think tlmgr is installed via this script.
https://github.com/rocker-org/rocker-versioned2/blob/c6152e1d5db5e29ee41d8bc0873de9b0ef17861b/scripts/install_texlive.sh

If we want to add these packages to rocker/binder, we may need to add a new script.
@cboettig Thoughts?

@cboettig
Copy link
Member

👍 Having support for Myst in binder would be nice. I think it makes sense to to call the install_texlive.sh first to add tlmgr to binder.

scripts/install_jupyter.sh Outdated Show resolved Hide resolved
scripts/install_jupyter.sh Outdated Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@yuvipanda
Copy link
Contributor Author

Yay, thanks @eitsupi.

The julia test failure looks intermittent and unrelated.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, merging now.

@eitsupi eitsupi merged commit cfc3942 into rocker-org:master Oct 20, 2023
32 of 33 checks passed
@yuvipanda
Copy link
Contributor Author

Yay! Thank you, @eitsupi! I appreciate it :)

Would this trigger a rebuild of the various rocker/binder: images? If not, would it be possible to kick off a rebuild of those?

@eitsupi
Copy link
Member

eitsupi commented Oct 20, 2023

Would this trigger a rebuild of the various rocker/binder: images? If not, would it be possible to kick off a rebuild of those?

Today's new release of RStudio Server has already triggered a build.
https://github.com/rocker-org/rocker-versioned2/actions/runs/6587176060

yuvipanda added a commit to 2i2c-org/utoronto-r-image that referenced this pull request Nov 1, 2023
- Matches what we do in other images
- Simplifies this image *a lot*
- Knitting still takes time the *first time* even if we just switch to
  new base image. But rocker-org/rocker-versioned2#714
  installs some of the texlive packages that are being installed the
  first time, and should speed things up.

Ref 2i2c-org/infrastructure#3178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants