Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Use latest Shiny Server build, and Add docker-compose file #37

Merged
merged 6 commits into from
Jul 13, 2018

Conversation

jglev
Copy link
Contributor

@jglev jglev commented Jul 2, 2018

Thank you for your work on this project!

I see that in #36, @wch mentioned that this project is not still active. Even with that in mind, I'm wondering whether you might still welcome this Pull Request. This PR does three things:

  1. Explicitly note in the Dockerfile where to find Shiny Server installation instructions (https://www.rstudio.com/products/shiny/download-server/).
  2. Update the Dockerfile to use the latest version of Shiny Server, from the instructions at the above URL.
  3. Add a docker-compose.yml file, facilitating use in larger Docker networks.

Even if this project is no longer maintained, its presence here and on Docker Hub helped me to get up and running more quickly just now. These changes could make it easier for other future users of this repo. to keep their installs up-to-date, as well.

Thank you for your consideration!

@cboettig
Copy link
Member

cboettig commented Jul 3, 2018

LGTM

@eddelbuettel
Copy link
Member

I might prefer the README.md to show docker-compose as an option rarther than the only choice as that would be a bit more in line with the rest of our setups.

Copy link

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks. I do agree with @eddelbuettel that it would be nice to keep the plain docker documentation as well. So perhaps split into 2 sections? The old one and a new one for docker-compose.

@jglev
Copy link
Contributor Author

jglev commented Jul 3, 2018 via email

Jacob Levernier added 2 commits July 9, 2018 14:22
…ocker usage, added instructions for custom configuration, and added example custom-mountpoint index and app.
@jglev
Copy link
Contributor Author

jglev commented Jul 9, 2018

I'm sorry for the delay with this, but am excited to have just pushed commits that:

  1. answer @eddelbuettel and @pieterlukasse's comments above re: retaining the original Docker use instructions,
  2. add additional documentation for the Dockerfile for building with a custom configuration file, and
  3. add additional documentation for using custom mountpoints and a persistent volume for app logs using the example docker-compose file.

@cboettig
Copy link
Member

Thanks for this, LGTM. Will go ahead and merge later this week if there are no further comments etc

@cboettig cboettig merged commit 4b23be9 into rocker-org:master Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants