This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 138
Use latest Shiny Server build, and Add docker-compose file #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
I might prefer the README.md to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks. I do agree with @eddelbuettel that it would be nice to keep the plain docker documentation as well. So perhaps split into 2 sections? The old one and a new one for docker-compose.
Closed
Thank you all! I'm happy to split the Readme into two sub-sections. I'm away from my computer most of today, but I look forward to doing so either this evening or Thursday (Given the US holiday tomorrow). I'd also like to add slightly to the documentation re: mountpoints, as I think about it more.
…On July 3, 2018 8:15:31 AM EDT, pieterlukasse ***@***.***> wrote:
pieterlukasse commented on this pull request.
this is great, thanks. I do agree with @eddelbuettel that it would be
nice to keep the plain docker documentation as well. So perhaps split
into 2 sections? The old one and a new one for docker-compose.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#37 (review)
|
…ocker usage, added instructions for custom configuration, and added example custom-mountpoint index and app.
I'm sorry for the delay with this, but am excited to have just pushed commits that:
|
Thanks for this, LGTM. Will go ahead and merge later this week if there are no further comments etc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your work on this project!
I see that in #36, @wch mentioned that this project is not still active. Even with that in mind, I'm wondering whether you might still welcome this Pull Request. This PR does three things:
docker-compose.yml
file, facilitating use in larger Docker networks.Even if this project is no longer maintained, its presence here and on Docker Hub helped me to get up and running more quickly just now. These changes could make it easier for other future users of this repo. to keep their installs up-to-date, as well.
Thank you for your consideration!