Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #106

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update index.md #106

merged 1 commit into from
Jan 12, 2024

Conversation

eddelbuettel
Copy link
Member

A friend pointed out that the r2u docs / my mentions refer to rocker/r2u, but it is not mentioned on the site. This PR adds a line to images/ to correct that.

A friend pointed out that the r2u docs / my mentions refer to rocker/r2u, but it is not mentioned on the site.  This PR adds a line to images/ to correct that.
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can #97 be closed?

@eddelbuettel
Copy link
Member Author

#97 is about a dedicated page which we could add for consistency. For expediency I referenced the external r2u page. Maybe that is better (to not have potentially stale info in two places) ? What do you think?

@eddelbuettel eddelbuettel merged commit 2b1205e into master Jan 12, 2024
6 checks passed
@eddelbuettel eddelbuettel deleted the eddelbuettel-patch-1 branch January 12, 2024 14:58
@eitsupi
Copy link
Member

eitsupi commented Jan 12, 2024

Yes, I thought that an external link would be sufficient too.
We can also link from the navigation bar in the same way as r-base.

image

@eitsupi eitsupi mentioned this pull request Jan 12, 2024
@eddelbuettel
Copy link
Member Author

Yes navbar change would be great. Can you put that in?

eitsupi added a commit that referenced this pull request Jan 12, 2024
A follow up for
#106 (comment)

Add the link to r2u page in the nav bar and sidebar like any other
images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants