Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Maintaining multiple installers slows down progress and opens too much room for inconsistency. This pull request aims to solve that by introducing an unified installer capable of performing different actions depending on the game that is to be installed.
Solution for the Installer
The installer now presents the user with a drop down where they can select which game they would like to install. Based on the selected game, the installer uses the gameinfo of that game to determine specifics of that game such as APPID, necessary winetricks, etc.
Adding a new game to this installer should be as simple as creating a new gameinfo file and adding a new option to the dropdown.
Note: while the installer gives the user an option to inform that their game is installed using Wine, this is still an upcoming feature and for now the user will simply receive an error informing it's not possible to use the installer with non-Steam games.
Solution for the NXM Link Handler
The installer links the installed instance's directory to a fixed location - $HOME/.config/modorganizer2/instances - and the broken then accesses this location to use the
download.sh
script which in turn starts thenxmhandler.exe
of that instance.Downsides
The only downsides of this approach are very minor and the pros far outweigh them. They are still worth noting, however: