Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starfield support #618

Merged
merged 3 commits into from
May 11, 2024
Merged

Add Starfield support #618

merged 3 commits into from
May 11, 2024

Conversation

sapphiria39
Copy link
Contributor

Hello, I'm pretty new to using GitHub so apologies if this isn't the right way of doing this.

I've added support for Starfield based on the comments here: #528

Since this requires MO2 v2.5.0, I added a mechanism for overriding the mo2_url via game_mo2_url in the gamesinfo scripts. It's also necessary to use Proton 9.0 (beta). And I needed to add a workaround for Data/SFSE/SFSE.ini to point to _Starfield.exe, similar to the Skyrim VR workaround.

I installed a handful of the popular mods and that all seemed to work. Would be good to have some others test it out as well.

It does feel a bit hacky to use game_mo2_url like this though, so I'm open to waiting until we've got the Proton 9 and MO2 v2.5.0 changes in place.

Copy link
Owner

@rockerbacon rockerbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MO2 and Proton updates are two separate issues. #582 #543

Please include only the Starfield changes in this PR. You can submit separate PRs for updating MO2, as well as the recommended Proton version.

@sapphiria39
Copy link
Contributor Author

Alright, I reverted the MO2 & Proton changes and re-tested the setup after merging latest.

@rockerbacon
Copy link
Owner

Thank you for your contribution!

@rockerbacon rockerbacon merged commit f4f728f into rockerbacon:master May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants