Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to RPIP-33 #123

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Updates to RPIP-33 #123

merged 2 commits into from
Dec 1, 2023

Conversation

kanewallmann
Copy link
Member

  1. Replacing vote time parameters with 2 phase ones
  2. Update technical information link to point to up-to-date version
  3. Clarify security.proposal.execute.time parameter

Valdorff
Valdorff approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@Valdorff Valdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses feedback and also splits the pDAO vote time parameter per phase to match the diagram

@Valdorff Valdorff merged commit 72689f5 into rocket-pool:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valdorff Valdorff Valdorff approved these changes

@darrenlangley darrenlangley Awaiting requested review from darrenlangley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kanewallmann @Valdorff