Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix portal inline Latex rendering #99

Merged
merged 6 commits into from Oct 30, 2023

Conversation

LongForWisdom
Copy link
Contributor

@LongForWisdom LongForWisdom commented Oct 30, 2023

Note: stackoverflow told me to do this. I know only enough to be dangerous...

It does work though, see staging: https://longforwisdom.github.io/RPIPs/RPIPs/RPIP-33#specification

Important note: Hit ctrl-f5 to clear styling cache to see updated version.

Note, this DOES NOT fix the problem with escaping % symbols being different between github and the portal. I would go with the suggestion of just not using them in the equation. I think this is related to the liquid syntax, but I can't find an easy way to work around it.

<script type="text/x-mathjax-config">
MathJax.Hub.Config({
tex2jax: {
skipTags: ['script', 'noscript', 'style', 'textarea', 'pre'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't strictly necessary apparently. But I don't want to remove it without knowing why it was there in the stackoverflow answer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked it up, it just tells the parser to skip certain html tags. You can ignore it.

@LongForWisdom LongForWisdom changed the title Fix Latex rendering Fix inline Latex rendering Oct 30, 2023
@LongForWisdom LongForWisdom changed the title Fix inline Latex rendering Fix portal inline Latex rendering Oct 30, 2023
Copy link
Collaborator

@Valdorff Valdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no-downside. Merging, and RPIP-30 will have some modest usage of the feature so we can see it irl.

@Valdorff Valdorff merged commit 1d8cbd6 into rocket-pool:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants