Add installation/setup instructions for Ubuntu #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusma
reviewed
May 15, 2020
doc/INSTALL-ubuntu.md
Outdated
| $ cd examples | ||
| $ export LD_LIBRARY_PATH="$(realpath lib):$LD_LIBRARY_PATH" | ||
| # ^ This is so the system can find libbass.so | ||
| $ ./example_bass & |
There was a problem hiding this comment.
Perhaps LD_LIBRARY_PATH="$(realpath lib)" ./example_bass so we don't suggest contaminating the shell? I also don't think previously set LD_LIBRARY_PATH needs to be preserved here...
There was a problem hiding this comment.
- Happy to put it on the same line --- I broke it into two just for spacing.
- I would strongly prefer to include the old
LD_LIBRARY_PATHjust in case a user has some weird setup. OK? (It could be worse ---"$(realpath lib)${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH}":D ). (Edit Really, I just don't want to get a bug report from somebody who has a bogus ld.so.conf but hasn't noticed it becauseLD_LIBRARY_PATHis compensating ;) .)
Also: - Added .md files to .editorconfig - Fixed typo in pathnames in README.md
Collapse cxw's entries together
|
Updated! I also had to add a .gitignore entry for a file created by the Qt5 make process. Thanks for the quick response and feedback! |
|
I see the build passed Travis (here), but the Travis status in GH shows as "Expected". Please let me know if there's anything I need to do! |
|
Sorry, I'm just low on time right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kusma,
I have switched from Win7 to Lubuntu and finally got Rocket set up the other day on the new OS \o/ . It took me a bit of trial and error to get everything right. I wrote up my notes and offer them in this PR for the benefit of others. Let me know what you think!
cxw